My Samsung Galaxy S5 cellphone is 5 years old (6 years since inception) and is showing its age. I replaced it with a Sony Xperia XA2 model H3123 (2 years since inception). It is doing a good job meeting these selection criteria:
It has a LineageOS (CyanogenMod) instance that is getting regular updates and which has a kernel which, though not exactly recent, is on long term support and is getting backported security patches.
It has a nice display in cellphone size (not phablet): 1920x1080px, 132mm diagonal, IPS backlit. It's excellent for e.g. map navigation in direct sunlight.
It is frugal in energy use, typically 30% battery per day, compared to 60% or more for the Galaxy S5 with its smaller and older battery. Other people may use more, particularly if they do social networking with push notifications.
It has a rear camera that's good for non-professional general photography: a 23Mpx sensor, f2.0 lens, 84° wide angle, auto focus and flash. Two different camera apps are able to get good pictures off it.
Here is more information about the Sony Xperia XA2.